[all-commits] [llvm/llvm-project] 9debc3: [mlir:PDL] Fix assembly format for pdl.apply_nativ...

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9debc35f02e90352e49ae5ce7bcfb0b7a233d81a
      https://github.com/llvm/llvm-project/commit/9debc35f02e90352e49ae5ce7bcfb0b7a233d81a
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/PDL/IR/PDLOps.td
    M mlir/test/Dialect/PDL/ops.mlir

  Log Message:
  -----------
  [mlir:PDL] Fix assembly format for pdl.apply_native_rewrite

The results of a rewrite are optional, but we currently require
them to be present in the assembly format. This commit
makes the results component in the format optional.

Differential Revision: https://reviews.llvm.org/D114814


  Commit: 98f5bd3489e68b65ae98d9424a24bc4c4ee021e7
      https://github.com/llvm/llvm-project/commit/98f5bd3489e68b65ae98d9424a24bc4c4ee021e7
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/PDL/IR/PDLOps.td
    M mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td
    M mlir/test/Dialect/PDL/ops.mlir

  Log Message:
  -----------
  [mlir:PDL] Adjust the assembly format for AttributeOp to avoid conflicts with DictionaryAttr

Switch the attribute creation operations to use attr-dict-with-
keyword to avoid conflicts (in the case of pdl.attribute) and
confusion(in the case of pdl_interp.create_attribute) with
having a DictionaryAttr as a value and specifying the
attributes of the operation itself (as a dictionary).

Differential Revision: https://reviews.llvm.org/D114815


  Commit: 06c3b9c7be727af0edb0ebe73375776b491c6b0b
      https://github.com/llvm/llvm-project/commit/06c3b9c7be727af0edb0ebe73375776b491c6b0b
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M mlir/lib/IR/PatternMatch.cpp
    M mlir/test/lib/Rewrite/TestPDLByteCode.cpp

  Log Message:
  -----------
  [mlir:PDL] Fix bugs in PDLPatternModule merging

* Constraints/Rewrites registered before a pattern was added were dropped
* Constraints/Rewrites may be registered multiple times (if different pattern sets depend on them)
* ModuleOp no longer has a terminator, so we shouldn't be removing the terminator from it

Differential Revision: https://reviews.llvm.org/D114816


  Commit: 233e9476d8bec85b7711041d7c7536ac6f87e9ef
      https://github.com/llvm/llvm-project/commit/233e9476d8bec85b7711041d7c7536ac6f87e9ef
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td
    M mlir/lib/Conversion/PDLToPDLInterp/PDLToPDLInterp.cpp
    M mlir/lib/Conversion/PDLToPDLInterp/Predicate.cpp
    M mlir/lib/Conversion/PDLToPDLInterp/Predicate.h
    M mlir/lib/Conversion/PDLToPDLInterp/PredicateTree.cpp
    M mlir/lib/Dialect/PDL/IR/PDL.cpp
    M mlir/test/Conversion/PDLToPDLInterp/pdl-to-pdl-interp-matcher.mlir

  Log Message:
  -----------
  [mlir:PDL] Allow non-bound pdl.attribute/pdl.type operations that create constants

This allows for passing in these attributes/types to constraints/rewrites as arguments.

Differential Revision: https://reviews.llvm.org/D114817


Compare: https://github.com/llvm/llvm-project/compare/e40624ae604f...233e9476d8be