[all-commits] [llvm/llvm-project] ec6870: [llvm] Make ScopedPrinter interface virtual

[Jayson Yan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ec6870b39cf75bf84a160322bc72b1a3abd69da8
      https://github.com/llvm/llvm-project/commit/ec6870b39cf75bf84a160322bc72b1a3abd69da8
  Author: Jayson Yan <jaysonyan at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M llvm/include/llvm/Support/ScopedPrinter.h

  Log Message:
  -----------
  [llvm] Make ScopedPrinter interface virtual

Make the interface provided by ScopedPrinter virtual to support a future
JSONScopedPrinter which will supply it's own implementation.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D114223


  Commit: 10602f2ae1ce663f88c452a199bc036394f3ccbd
      https://github.com/llvm/llvm-project/commit/10602f2ae1ce663f88c452a199bc036394f3ccbd
  Author: Jayson Yan <jaysonyan at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M llvm/include/llvm/Support/ScopedPrinter.h

  Log Message:
  -----------
  [NFC] Remove unneeded printString methods

Both std::string and char * implicitly convert to StringRef so
the overloaded method using std::string and char* are unneeded.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D114740


  Commit: 80a0ee6f64b9274d51cec80a141f10c627b895f0
      https://github.com/llvm/llvm-project/commit/80a0ee6f64b9274d51cec80a141f10c627b895f0
  Author: Jayson Yan <jaysonyan at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M llvm/include/llvm/Support/ScopedPrinter.h

  Log Message:
  -----------
  [NFC] Move printNumber method

Move printNumber(StringRef Label, StringRef Str, T Value) to
be with the rest of the printNumber(...) methods.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D114741


  Commit: d25a65030bc136ab9dfe68a9c3bc10399c204364
      https://github.com/llvm/llvm-project/commit/d25a65030bc136ab9dfe68a9c3bc10399c204364
  Author: Jayson Yan <jaysonyan at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M llvm/unittests/Support/CMakeLists.txt
    A llvm/unittests/Support/ScopedPrinterTest.cpp

  Log Message:
  -----------
  [llvm] Add ScopedPrinter unit tests

Add unit tests for the ScopedPrinter class.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D114684


  Commit: 928d17254ba214749dbd58f6d5604c11057a60bc
      https://github.com/llvm/llvm-project/commit/928d17254ba214749dbd58f6d5604c11057a60bc
  Author: Jayson Yan <jaysonyan at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M llvm/include/llvm/Support/ScopedPrinter.h
    M llvm/lib/Support/ScopedPrinter.cpp
    M llvm/tools/llvm-readobj/ARMEHABIPrinter.h
    M llvm/unittests/Support/ScopedPrinterTest.cpp

  Log Message:
  -----------
  [llvm] Add JSONScopedPrinter class

This change adds a JSONScopedPrinter as a subclass to ScopedPrinter.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D114224


  Commit: 824eef231a853d7054d55010c16654f6f20e0394
      https://github.com/llvm/llvm-project/commit/824eef231a853d7054d55010c16654f6f20e0394
  Author: Jayson Yan <jaysonyan at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M llvm/docs/CommandGuide/llvm-readelf.rst
    M llvm/docs/CommandGuide/llvm-readobj.rst
    A llvm/test/tools/llvm-readobj/ELF/file-summary-json.test
    M llvm/test/tools/llvm-readobj/ELF/output-style.test
    A llvm/test/tools/llvm-readobj/ELF/pretty-print.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp
    M llvm/tools/llvm-readobj/ObjDumper.cpp
    M llvm/tools/llvm-readobj/ObjDumper.h
    M llvm/tools/llvm-readobj/Opts.td
    M llvm/tools/llvm-readobj/llvm-readobj.cpp
    M llvm/tools/llvm-readobj/llvm-readobj.h

  Log Message:
  -----------
  [llvm-readobj] Add JSONScopedPrinter to llvm-readelf

 Adds JSONScopedPrinter to llvm-readelf. It includes an empty
 JSONELFDumper class which will be used to override any LLVMELFDumper
 methods which utilize startLine() which JSONScopedPrinter cannot
 provide.

 Reviewed By: jhenderson

 Differential Revision: https://reviews.llvm.org/D114225


Compare: https://github.com/llvm/llvm-project/compare/7f09aee0f6b4...824eef231a85