[all-commits] [llvm/llvm-project] d7c07f: [X86][MS-InlineAsm] Make the constraint *m to be s...

Phoebe Wang via All-commits all-commits at lists.llvm.org
Thu Dec 9 17:29:56 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d7c07f60b35f901f5bd9153b11807124a9bdde60
      https://github.com/llvm/llvm-project/commit/d7c07f60b35f901f5bd9153b11807124a9bdde60
  Author: Phoebe Wang <phoebe.wang at intel.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M clang/test/CodeGen/X86/ms_fmul.c
    M clang/test/CodeGen/ms-inline-asm-functions.c
    M clang/test/CodeGen/ms-inline-asm-static-variable.c
    M clang/test/CodeGen/ms-inline-asm-variables.c
    M llvm/include/llvm/MC/MCParser/MCParsedAsmOperand.h
    M llvm/lib/MC/MCParser/AsmParser.cpp
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
    M llvm/lib/Target/X86/AsmParser/X86Operand.h
    M llvm/test/CodeGen/X86/ms-inline-asm-array.ll

  Log Message:
  -----------
  [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

D113096 solved the "undefined reference to xxx" issue by adding
constraint *m for the global var. But it has strong side effect due to
the symbol in the assembly being replaced with constraint variable.
This leads to some lowering fails. https://godbolt.org/z/h3nWoerPe

This patch fix the problem by use the constraint *m as place holder
rather than real constraint. It has negligible effect for the existing
code generation.

Reviewed By: skan

Differential Revision: https://reviews.llvm.org/D115225




More information about the All-commits mailing list