[all-commits] [llvm/llvm-project] f72e50: [lsan] Reduce StopTheWorld access to StackDepot

Vitaly Buka via All-commits all-commits at lists.llvm.org
Thu Dec 9 11:43:43 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f72e50946c713c1e2444abd4a2e3f455ebb1045e
      https://github.com/llvm/llvm-project/commit/f72e50946c713c1e2444abd4a2e3f455ebb1045e
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2021-12-09 (Thu, 09 Dec 2021)

  Changed paths:
    M compiler-rt/lib/lsan/lsan_common.cpp
    M compiler-rt/lib/lsan/lsan_common.h

  Log Message:
  -----------
  [lsan] Reduce StopTheWorld access to StackDepot

StackDepot locks some stuff. As is there is small probability to
deadlock if we stop thread which locked the Depot.

We need either Lock/Unlock StackDepot for StopTheWorld, or don't
interact with StackDepot from there.

This patch does not run LeakReport under StopTheWorld. LeakReport
contains most of StackDepot access.

As a bonus this patch will help to resolve kMaxLeaksConsidered FIXME.

Depends on D114498.

Reviewed By: morehouse, kstoimenov

Differential Revision: https://reviews.llvm.org/D115284




More information about the All-commits mailing list