[all-commits] [llvm/llvm-project] 0d13f9: [reductions] Delete another piece of dead flag han...

Philip Reames via All-commits all-commits at lists.llvm.org
Thu Dec 9 10:57:14 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d13f94c1da994e5ad6cf18206d6ca2f6056ef02
      https://github.com/llvm/llvm-project/commit/0d13f94c1da994e5ad6cf18206d6ca2f6056ef02
  Author: Philip Reames <listmail at philipreames.com>
  Date:   2021-12-09 (Thu, 09 Dec 2021)

  Changed paths:
    M llvm/lib/Transforms/Utils/LoopUtils.cpp

  Log Message:
  -----------
  [reductions] Delete another piece of dead flag handling [NFC]

The code claimed to handle nsw/nuw, but those aren't passed via builder state and the explicit IR construction just above never sets them.

The only case this bit of code is actually relevant for is FMF flags.  However, dropPoisonGeneratingFlags currently doesn't know about FMF at all, so this was a noop.  It's also unneeded, as the caller explicitly configures the flags on the builder before this call, and the flags on the individual ops should be controled by the intrinsic flags anyways.  If any of the flags aren't safe to propagate, the caller needs to make that change.




More information about the All-commits mailing list