[all-commits] [llvm/llvm-project] a92cf7: AMDGPU: Mark SCC def as dead when expanding frame ...

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a92cf7cea5383c7c2920b803cf7aa2167dec9fa6
      https://github.com/llvm/llvm-project/commit/a92cf7cea5383c7c2920b803cf7aa2167dec9fa6
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
    M llvm/test/CodeGen/AMDGPU/pei-scavenge-sgpr-carry-out.mir
    M llvm/test/CodeGen/AMDGPU/pei-scavenge-sgpr-gfx9.mir
    M llvm/test/CodeGen/AMDGPU/pei-scavenge-sgpr.mir
    M llvm/test/CodeGen/AMDGPU/pei-scavenge-vgpr-spill.mir
    M llvm/test/CodeGen/AMDGPU/sgpr-spill.mir

  Log Message:
  -----------
  AMDGPU: Mark SCC def as dead when expanding frame indexes

This improves liveness queries in a future change.


  Commit: 0383872295bed5f393a174bac827b25c3d24a3cf
      https://github.com/llvm/llvm-project/commit/0383872295bed5f393a174bac827b25c3d24a3cf
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/sgpr-spill-incorrect-fi-bookkeeping-bug.ll

  Log Message:
  -----------
  AMDGPU: Simplify test for SGPR spilling bug

Remove the control flow from the test from
25eb7fa01d7ebbe67648ea03841cda55b4239ab2. It's not necessary to
reproduce the original assert with the patch reverted. The control
flow happens to expose a different issue that calls for a separate
test in a future change.


  Commit: 017ef7854972e8ad9386bf8eaf4bde7a8123d0ff
      https://github.com/llvm/llvm-project/commit/017ef7854972e8ad9386bf8eaf4bde7a8123d0ff
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
    A llvm/test/CodeGen/AMDGPU/scc-clobbered-sgpr-to-vmem-spill.ll

  Log Message:
  -----------
  AMDGPU: Mark scc defs dead in SGPR to VMEM path for no free SGPRs

This introduces verifier errors into this broken situation which we do
not handle correctly, which is better than being silently
miscompiled. For the emergency stack slot, the scavenger likes to move
the restore instruction as late as possible, which ends up separating
the SCC def from the conditional branch.


Compare: https://github.com/llvm/llvm-project/compare/de8d26ac0264...017ef7854972