[all-commits] [llvm/llvm-project] ccf146: [lldb] Make lldbVersion a full fledged library
Jonas Devlieghere via All-commits
all-commits at lists.llvm.org
Wed Dec 8 15:14:47 PST 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: ccf1469a4cdb03cb2bc7868f76164e85d90ebee1
https://github.com/llvm/llvm-project/commit/ccf1469a4cdb03cb2bc7868f76164e85d90ebee1
Author: Jonas Devlieghere <jonas at devlieghere.com>
Date: 2021-12-08 (Wed, 08 Dec 2021)
Changed paths:
A lldb/include/lldb/Version/Version.h
A lldb/include/lldb/Version/Version.inc.in
M lldb/include/lldb/lldb-private.h
M lldb/source/API/CMakeLists.txt
M lldb/source/API/SBDebugger.cpp
M lldb/source/API/SBReproducer.cpp
M lldb/source/CMakeLists.txt
M lldb/source/Commands/CMakeLists.txt
M lldb/source/Commands/CommandObjectVersion.cpp
M lldb/source/Initialization/SystemInitializerCommon.cpp
A lldb/source/Version/CMakeLists.txt
A lldb/source/Version/Version.cpp
M lldb/tools/lldb-server/CMakeLists.txt
M lldb/tools/lldb-server/lldb-server.cpp
M lldb/tools/lldb-test/CMakeLists.txt
Log Message:
-----------
[lldb] Make lldbVersion a full fledged library
Because of its dependency on clang (and potentially other compilers
downstream, such as swift) lldb_private::GetVersion already lives in its
own library called lldbBase. Despite that, its implementation was spread
across unrelated files. This patch improves things by introducing a
Version library with its own directory, header and implementation file.
The benefits of this patch include:
- We can get rid of the ugly quoting macros.
- Other parts of LLDB can read the version number from
lldb/Version/Version.inc.
- The implementation can be swapped out for tools like lldb-server than
don't need to depend on clang at all.
Differential revision: https://reviews.llvm.org/D115211
More information about the All-commits
mailing list