[all-commits] [llvm/llvm-project] 67c43d: [libc++] [test_iterators] Make all ADL base() func...

[Quuxplusone via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 67c43d87cd53fdbd75dea6da8dbbd0762357864a
      https://github.com/llvm/llvm-project/commit/67c43d87cd53fdbd75dea6da8dbbd0762357864a
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M libcxx/test/support/test_iterators.h

  Log Message:
  -----------
  [libc++] [test_iterators] Make all ADL base() functions into hidden friends. NFCI.

This follows up on my addition of base(cpp20_input_iterator) in D115177,
making all the ADL base() functions consistent.
Also align cpp20_input_iterator with the other test iterators' style.

Reviewed as part of D115272.


  Commit: c19d8f955ac3a807978c199fdc4262680d3ad5b2
      https://github.com/llvm/llvm-project/commit/c19d8f955ac3a807978c199fdc4262680d3ad5b2
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M libcxx/test/std/ranges/range.access/range.prim/ssize.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Use sized_sentinel<int*> in range.prim/ssize.pass.cpp.

Reviewed as part of D115272.


  Commit: f638c4d6e4a28fbd5508f853a8715cc92bb66d48
      https://github.com/llvm/llvm-project/commit/f638c4d6e4a28fbd5508f853a8715cc92bb66d48
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M libcxx/test/std/ranges/range.access/range.prim/empty.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Refactor range.prim/empty.pass.cpp.

No decrease in test coverage intended. The original goal here
was just to get rid of the global name `sentinel` so that we can
rename the `sentinel_wrapper` in "test_iterators.h" to `sentinel`;
but then I took a closer look at the offending tests and saw
that some of them probably weren't testing what they intended.

Also, add one `/*explicit*/` and one #if'ed out test indicating
bugs in the current ranges::empty (to be fixed by D115312 or
some equivalent patch).

Reviewed as part of D115272.


Compare: https://github.com/llvm/llvm-project/compare/aff028f7d832...f638c4d6e4a2