[all-commits] [llvm/llvm-project] 5d3b89: Don't offer partial fix-its for `modernize-pass-by...

[Aaron Ballman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d3b8956e83484ff7234dda5e939abbdc9bd2c88
      https://github.com/llvm/llvm-project/commit/5d3b8956e83484ff7234dda5e939abbdc9bd2c88
  Author: Adrian Vogelsgesang <avogelsgesang at salesforce.com>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
    M clang-tools-extra/test/clang-tidy/checkers/modernize-pass-by-value.cpp

  Log Message:
  -----------
  Don't offer partial fix-its for `modernize-pass-by-value`

This commit improves the fix-its of modernize-pass-by-value by
no longer proposing partial fixes. In the presence of using/typedef,
we failed to rewrite the function signature but still adjusted the
function body. This led to incorrect, partial fix-its. Instead, the
check now simply doesn't offer any fixes at all in such a situation.