[all-commits] [llvm/llvm-project] 3257f6: [NFC][CodeGen] Remove rarely used DL variable from...

david-arm via All-commits all-commits at lists.llvm.org
Wed Dec 8 09:06:00 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3257f63bbd9d75cf39abcd94201ed33d9c244dd6
      https://github.com/llvm/llvm-project/commit/3257f63bbd9d75cf39abcd94201ed33d9c244dd6
  Author: David Sherwood <david.sherwood at arm.com>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h

  Log Message:
  -----------
  [NFC][CodeGen] Remove rarely used DL variable from SelectionDAGBuilder

There is a pointer to the DataLayout in SelectionDAGBuilder called
'DL' that is hardly ever used. In most cases the code seems to just
use `DAG.getDataLayout()` instead. Given that DL is also often used
as a shadowed variable for the debug location it seems sensible to
just kill off the few remaining uses and be consistent with the rest
of the code.

Differential Revision: https://reviews.llvm.org/D114451




More information about the All-commits mailing list