[all-commits] [llvm/llvm-project] ae316a: [lldb/qemu] Sort entries in QEMU_(UN)SET_ENV

Pavel Labath via All-commits all-commits at lists.llvm.org
Wed Dec 8 06:56:50 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ae316ac66ffff430997e342772fc4629c1acece0
      https://github.com/llvm/llvm-project/commit/ae316ac66ffff430997e342772fc4629c1acece0
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2021-12-08 (Wed, 08 Dec 2021)

  Changed paths:
    M lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp

  Log Message:
  -----------
  [lldb/qemu] Sort entries in QEMU_(UN)SET_ENV

The test for this functionality was failing on the darwin bot, because
the entries came out in opposite order. While this does not impact
functionality, and the algorithm that produces it is technically
deterministic (the nondeterminism comes from the contents of the host
environment), it seems like it would be more user-friendly if the
entries came out in a more predictible order.

Therefore I am adding the sort call to the actual code instead of
relaxing test expectations.




More information about the All-commits mailing list