[all-commits] [llvm/llvm-project] 04d74a: [libc++] std::move should be _VSTD::move in one pl...

[Quuxplusone via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04d74aaff95984fba4572ce0d00fea43063462c6
      https://github.com/llvm/llvm-project/commit/04d74aaff95984fba4572ce0d00fea43063462c6
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-12-07 (Tue, 07 Dec 2021)

  Changed paths:
    M libcxx/include/__ranges/subrange.h

  Log Message:
  -----------
  [libc++] std::move should be _VSTD::move in one place. NFCI.

Reviewed as part of D115177.


  Commit: 7a06a14f624d31e7ed920f254d8b733d535258cb
      https://github.com/llvm/llvm-project/commit/7a06a14f624d31e7ed920f254d8b733d535258cb
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-12-07 (Tue, 07 Dec 2021)

  Changed paths:
    M libcxx/include/__compare/strong_order.h
    M libcxx/include/__compare/weak_order.h

  Log Message:
  -----------
  [libc++] Remove unneeded `std::` qualifications from <compare>. NFCI.

Reviewed as part of D115177.


  Commit: bd0c0e5b8c8c0bff5ffdff3d1d43dfbacf9caa06
      https://github.com/llvm/llvm-project/commit/bd0c0e5b8c8c0bff5ffdff3d1d43dfbacf9caa06
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-12-07 (Tue, 07 Dec 2021)

  Changed paths:
    M libcxx/include/__ranges/counted.h
    A libcxx/test/libcxx/ranges/range.adaptors/range.counted/adaptor.nodiscard.verify.cpp
    M libcxx/test/std/ranges/range.adaptors/range.counted/counted.pass.cpp
    M libcxx/test/support/test_iterators.h

  Log Message:
  -----------
  [libc++] [ranges] SFINAE-friendly "write it three times" in views::counted.

Before this patch, the new test's `CountedInvocable<int*, int*>`
would hard-error instead of SFINAEing and cleanly returning false.

Notice that views::counted specifically does NOT work with pipes;
`counted(42)` is ill-formed. This is because `counted`'s first argument
is supposed to be an iterator, not a range.

Also, mark `views::counted(it, n)` as [[nodiscard]], and test that.
(We have a general policy now that range adaptors are consistently
marked [[nodiscard]], so that people don't accidentally think that
they have side effects. This matters mostly for `reverse` and
`transform`, arguably `drop`, and just generally let's be consistent.)

Differential Revision: https://reviews.llvm.org/D115177


  Commit: b108cd7b4539a9314df09aa06142c9ab741a14e3
      https://github.com/llvm/llvm-project/commit/b108cd7b4539a9314df09aa06142c9ab741a14e3
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-12-07 (Tue, 07 Dec 2021)

  Changed paths:
    M libcxx/test/libcxx/ranges/range.adaptors/range.all/all.nodiscard.verify.cpp
    M libcxx/test/libcxx/ranges/range.adaptors/range.common.view/adaptor.nodiscard.verify.cpp
    A libcxx/test/libcxx/ranges/range.adaptors/range.reverse/adaptor.nodiscard.verify.cpp
    M libcxx/test/libcxx/ranges/range.adaptors/range.transform/adaptor.nodiscard.verify.cpp
    R libcxx/test/std/ranges/range.adaptors/range.reverse/adaptor.nodiscard.verify.cpp

  Log Message:
  -----------
  [libc++] [test] Rationalize the nodiscard tests for range adaptors.

Reviewed as part of D115177.


Compare: https://github.com/llvm/llvm-project/compare/4f2ec7f983b4...b108cd7b4539