[all-commits] [llvm/llvm-project] f1585a: Windows: support `DoLoadImage`

Saleem Abdulrasool via All-commits all-commits at lists.llvm.org
Sat Dec 4 11:12:14 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f1585a4b47cc9c08c9a4c10058597f4b7468c227
      https://github.com/llvm/llvm-project/commit/f1585a4b47cc9c08c9a4c10058597f4b7468c227
  Author: Saleem Abdulrasool <compnerd at compnerd.org>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M lldb/source/Plugins/Platform/Windows/CMakeLists.txt
    M lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
    M lldb/source/Plugins/Platform/Windows/PlatformWindows.h
    A lldb/test/Shell/Process/Windows/process_load.cpp

  Log Message:
  -----------
  Windows: support `DoLoadImage`

This implements `DoLoadImage` and `UnloadImage` in the Windows platform
plugin modelled after the POSIX platform plugin.  This was previously
unimplemented and resulted in a difficult to decipher error without any
logging.

This implementation is intended to support enables the use of LLDB's
Swift REPL on Windows.

Paths which are added to the library search path are persistent and
applied to all subsequent loads.  This can be adjusted in the future by
storing all the cookies and restoring the path prior to returning from
the helper.  However, the dynamic path count makes this a bit more
challenging.

Reviewed By: @JDevlieghere
Differential Revision: https://reviews.llvm.org/D77287




More information about the All-commits mailing list