[all-commits] [llvm/llvm-project] 946eb7: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

Carlos Galvez via All-commits all-commits at lists.llvm.org
Sat Dec 4 00:51:18 PST 2021

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 946eb7a037d5f83ea9cdc99bac0f939ddd344e09
  Author: Carlos Galvez <carlosgalvezp at gmail.com>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
    M clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
    M clang-tools-extra/clang-tidy/GlobList.cpp
    M clang-tools-extra/clang-tidy/GlobList.h
    M clang-tools-extra/unittests/clang-tidy/GlobListTest.cpp

  Log Message:
  [clang-tidy][NFC] Move CachedGlobList to GlobList.h

Currently it's hidden inside ClangTidyDiagnosticConsumer,
so it's hard to know it exists.

Given that there are multiple uses of globs in clang-tidy,
it makes sense to have these classes publicly available
for other use cases that might benefit from it.

Also, add unit test by converting the existing tests
for GlobList into typed tests.

Reviewed By: salman-javed-nz

Differential Revision: https://reviews.llvm.org/D113422

More information about the All-commits mailing list