[all-commits] [llvm/llvm-project] dc5e1d: [Bazel] Set the right default for LLVM_WINDOWS_PRE...

[Geoffrey Martin-Noble via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc5e1d06b917393cc7def06ede954e932ba59aaf
      https://github.com/llvm/llvm-project/commit/dc5e1d06b917393cc7def06ede954e932ba59aaf
  Author: Geoffrey Martin-Noble <gcmn at google.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M utils/bazel/llvm-project-overlay/llvm/config.bzl
    M utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h

  Log Message:
  -----------
  [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows

This cmake configure option was added in
df0ba47c36f6bd0865e3286853b76d37e037c2d7, and was ported to
Bazel in 7d323dc7738e3152c4bd54a23ac27554bfbbf583.

However, the setting chosen in Bazel seems accidental, not necessarily
intentional.

LLVM_WINDOWS_PREFER_FORWARD_SLASH has no effect on Unix, and on
Windows, setting it to 0 is the default, which gets the same behaviour
as before. Setting it to 1 enables new experimental behaviours
(which is enabled by default on MinGW targets only).

As I don't see any explicit intent to opt in to the new experimental
behaviour, I believe the current configuration in bazel was a
mistake.

Differential Revision: https://reviews.llvm.org/D114065