[all-commits] [llvm/llvm-project] 081074: [clang-tidy] Allow disabling support for NOLINTBEG...

Yitzhak Mandelbaum via All-commits all-commits at lists.llvm.org
Thu Dec 2 14:19:52 PST 2021

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 081074e1ea5353a3775591f7306b6fb6da02b004
  Author: Yitzhak Mandelbaum <yitzhakm at google.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
    M clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h

  Log Message:
  [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

This patch parameterizes the clang-tidy diagnostic consumer with a boolean that
controls whether to honor NOLINTBEGIN/NOLINTEND blocks. The current support for
scanning these blocks is very costly -- O(n*m) in the size of files (n) and
number of diagnostics found (m), with a large constant factor.  So, the patch
allows clients to disable it.

Future patches should make the feature more efficient, but this will mitigate in
the interim.

Differential Revision: https://reviews.llvm.org/D114981

More information about the All-commits mailing list