[all-commits] [llvm/llvm-project] 7ce8c6: [Flang] Replace notifyMatchFailure with TODO hard ...

kiranchandramohan via All-commits all-commits at lists.llvm.org
Thu Dec 2 02:25:38 PST 2021

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ce8c6fcf1e3d0f22c11ef827b9e152a00de7eae
  Author: Kiran Chandramohan <kiran.chandramohan at arm.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/CodeGen.cpp
    M flang/test/CMakeLists.txt
    A flang/test/Fir/Todo/boxproc_host.fir
    A flang/test/Fir/Todo/dispatch.fir
    A flang/test/Fir/Todo/dispatch_table.fir
    A flang/test/Fir/Todo/emboxproc.fir
    A flang/test/Fir/Todo/end.fir
    A flang/test/Fir/Todo/gentypedesc.fir
    A flang/test/Fir/Todo/global_len.fir
    A flang/test/Fir/Todo/len_param_index.fir
    A flang/test/Fir/Todo/select_case_with_character.fir
    A flang/test/Fir/Todo/unboxproc.fir
    M flang/test/Fir/convert-to-llvm-invalid.fir
    M flang/test/lit.cfg.py

  Log Message:
  [Flang] Replace notifyMatchFailure with TODO hard failures

For unimplemented patterns we revert to using TODO hard failures instead of

For fir.select_type revert to using mlir::emiterror.
For the fir.embox TODO on a type with len params we cannot add a test since the type cannot be converted to llvm.

Adding negative tests using not and checking for the error message.
TODO exits with an error in a build without assertion but aborts in a
build with assertions. Abort requires using not with the --crash
option. The two different usages of not is handled by using a custom
command %not_todo_cmd which is converted to not or not --crash
depending on the presence or absence of assertions. Using llvm-config
to check the presence of assertions.

Reviewed By: clementval, awarzynski

Differential Revision: https://reviews.llvm.org/D114371

More information about the All-commits mailing list