[all-commits] [llvm/llvm-project] 738636: Revert "[MLIR] Update Vector To LLVM conversion to...

stephenneuendorffer via All-commits all-commits at lists.llvm.org
Tue Nov 30 15:18:41 PST 2021

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 73863648892ee7063c7fd4e658d7614fd721504a
  Author: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
  Date:   2021-11-30 (Tue, 30 Nov 2021)

  Changed paths:
    M mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
    M mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir

  Log Message:
  Revert "[MLIR] Update Vector To LLVM conversion to be aware of assume_alignment"

This reverts commit 29a50c5864ddab283c1ff38694fb5926ce37b39a.

After LLVM lowering, the original patch incorrectly moved alignment
information across an unconstrained GEP operation.  This is only correct
for some index offsets in the GEP.  It seems that the best approach is,
in fact, to rely on LLVM to propagate information from the llvm.assume()
to users.

Thanks to Thomas Raoux for catching this.

More information about the All-commits mailing list