[all-commits] [llvm/llvm-project] f02c5f: [Analyzer][solver] Do not remove the simplified sy...
Gabor Marton via All-commits
all-commits at lists.llvm.org
Tue Nov 30 02:24:15 PST 2021
Author: Gabor Marton <gabor.marton at ericsson.com>
Date: 2021-11-30 (Tue, 30 Nov 2021)
[Analyzer][solver] Do not remove the simplified symbol from the eq class
Currently, during symbol simplification we remove the original member symbol
from the equivalence class (`ClassMembers` trait). However, we keep the
reverse link (`ClassMap` trait), in order to be able the query the
related constraints even for the old member. This asymmetry can lead to
a problem when we merge equivalence classes:
ClassA: [a, b] // ClassMembers trait,
a->a, b->a // ClassMap trait, a is the representative symbol
Now lets delete `a`:
Let's merge the trivial class `c` into ClassA:
ClassA: [c, b]
c->c, b->c, a->a
Now after the merge operation, `c` and `a` are actually in different
equivalence classes, which is inconsistent.
One solution to this problem is to simply avoid removing the original
member and this is what this patch does.
Other options I have considered:
1) Always merge the trivial class into the non-trivial class. This might
work most of the time, however, will fail if we have to merge two
non-trivial classes (in that case we no longer can track equivalences
2) In `removeMember`, update the reverse link as well. This would cease
the inconsistency, but we'd loose precision since we could not query
the constraints for the removed member.
Differential Revision: https://reviews.llvm.org/D114619
More information about the All-commits