[all-commits] [llvm/llvm-project] a9f837: NFC: Simplify sve-widen-phi.ll by unrolling once.

sdesmalen-arm via All-commits all-commits at lists.llvm.org
Sun Nov 28 01:50:28 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a9f837bbf0ecb12fd309a1c5ba59661fc1447327
      https://github.com/llvm/llvm-project/commit/a9f837bbf0ecb12fd309a1c5ba59661fc1447327
  Author: Sander de Smalen <sander.desmalen at arm.com>
  Date:   2021-11-28 (Sun, 28 Nov 2021)

  Changed paths:
    M llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-phi.ll

  Log Message:
  -----------
  NFC: Simplify sve-widen-phi.ll by unrolling once.

The unroll factor > 1 has little value for what is being tested.


  Commit: 28a4deab921d2d9a1e27d520fc3f745eb8d9aa02
      https://github.com/llvm/llvm-project/commit/28a4deab921d2d9a1e27d520fc3f745eb8d9aa02
  Author: Sander de Smalen <sander.desmalen at arm.com>
  Date:   2021-11-28 (Sun, 28 Nov 2021)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
    M llvm/test/Transforms/LoopVectorize/AArch64/predication_costs.ll
    M llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-gep.ll
    M llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-phi.ll
    M llvm/test/Transforms/LoopVectorize/consecutive-ptr-uniforms.ll
    M llvm/test/Transforms/LoopVectorize/pointer-induction.ll

  Log Message:
  -----------
  [LV] Fix incorrectly marking a pointer indvar as 'scalar'.

collectLoopScalars should only add non-uniform nodes to the list if they
are used by a load/store instruction that is marked as CM_Scalarize.

Before this patch, the LV incorrectly marked pointer induction variables
as 'scalar' when they required to be widened by something else,
such as a compare instruction, and weren't used by a node marked as
'CM_Scalarize'. This case is covered by sve-widen-phi.ll.

This change also allows removing some code where the LV tried to
widen the PHI nodes with a stepvector, even though it was marked as
'scalarAfterVectorization'. Now that this code is more careful about
marking instructions that need widening as 'scalar', this code has
become redundant.

Differential Revision: https://reviews.llvm.org/D114373


Compare: https://github.com/llvm/llvm-project/compare/cc2794abeab5...28a4deab921d


More information about the All-commits mailing list