[all-commits] [llvm/llvm-project] f074bb: [MLIR] Simplex::pivot: also update the redundant r...

[Arjun P via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f074bbb04a617f366093a860e5b0976d80129ff4
      https://github.com/llvm/llvm-project/commit/f074bbb04a617f366093a860e5b0976d80129ff4
  Author: Arjun P <arjunpitchanathan at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mlir/lib/Analysis/Presburger/Simplex.cpp
    M mlir/unittests/Analysis/Presburger/SimplexTest.cpp

  Log Message:
  -----------
  [MLIR] Simplex::pivot: also update the redundant rows when pivoting

Previously, the pivot function would only update the non-redundant rows when
pivoting. This is incorrect because in some cases, when rolling back past a
`detectRedundant` call, the basis being used could be different from that which
was used at the time of returning from the `detectRedundant` call. Therefore,
it is important to update the redundant rows as well during pivots. This could
also be triggered by pivots that occur when testing successive constraints for
being redundant in `detectRedundant` after some initial constraints are marked redundant.

Reviewed By: Groverkss

Differential Revision: https://reviews.llvm.org/D114614