[all-commits] [llvm/llvm-project] 7dc9a0: [libc++] Add missing __format__ attributes

Louis Dionne via All-commits all-commits at lists.llvm.org
Fri Nov 26 08:03:28 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7dc9a03cfd789e6a08ca96666e9fbb81431eb34f
      https://github.com/llvm/llvm-project/commit/7dc9a03cfd789e6a08ca96666e9fbb81431eb34f
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M libcxx/include/__bsd_locale_fallbacks.h
    M libcxx/include/__config
    M libcxx/src/filesystem/filesystem_common.h

  Log Message:
  -----------
  [libc++] Add missing __format__ attributes

-Wformat-nonliteral was turned on in https://reviews.llvm.org/D112927,
however we forgot to apply some __format__ attributes in Linux specific
code paths, which led to warnings when building on Linux. This patch
addresses that oversight.

Differential Revision: https://reviews.llvm.org/D113876


  Commit: f18f9ce3665e51e5f09a3d32f9e36fd24e3a79f7
      https://github.com/llvm/llvm-project/commit/f18f9ce3665e51e5f09a3d32f9e36fd24e3a79f7
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M libcxx/test/libcxx/selftest/dsl/dsl.sh.py
    M libcxx/utils/libcxx/test/dsl.py

  Log Message:
  -----------
  [libc++] Properly handle errors happening during Lit configuration

Instead of silently swallowing errors that happen during Lit configuration
(for example trying to obtain compiler macros but compiling fails), raise
an exception with some amount of helpful information.

This should avoid the possibility of silently configuring Lit in a bogus
way, and also provides more helpful information when things fail.

Note that this requires a bit more finesse around how we handle some
failing configuration checks that we would previously return None for.

Differential Revision: https://reviews.llvm.org/D114010


Compare: https://github.com/llvm/llvm-project/compare/0df522969a7a...f18f9ce3665e


More information about the All-commits mailing list