[all-commits] [llvm/llvm-project] 187d99: cfi: fix more -Wformat warnings

Dimitry Andric via All-commits all-commits at lists.llvm.org
Wed Nov 24 12:48:44 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 187d9979f22e9e285d501b53c0978c1e80856fa1
      https://github.com/llvm/llvm-project/commit/187d9979f22e9e285d501b53c0978c1e80856fa1
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2021-11-24 (Wed, 24 Nov 2021)

  Changed paths:
    M compiler-rt/lib/cfi/cfi.cpp

  Log Message:
  -----------
  cfi: fix more -Wformat warnings

Building cfi with recent clang on a 64-bit system results in the
following warnings:

    compiler-rt/lib/cfi/cfi.cpp:233:64: warning: format specifies type 'void *' but the argument has type '__sanitizer::uptr' (aka 'unsigned long') [-Wformat]
        VReport(1, "Can not handle: symtab > strtab (%p > %zx)\n", symtab, strtab);
                                                     ~~            ^~~~~~
                                                     %lu
    compiler-rt/lib/sanitizer_common/sanitizer_common.h:231:46: note: expanded from macro 'VReport'
        if ((uptr)Verbosity() >= (level)) Report(__VA_ARGS__); \
                                                 ^~~~~~~~~~~
    compiler-rt/lib/cfi/cfi.cpp:253:59: warning: format specifies type 'void *' but the argument has type '__sanitizer::uptr' (aka 'unsigned long') [-Wformat]
        VReport(1, "Can not handle: symtab %p, strtab %zx\n", symtab, strtab);
                                           ~~                 ^~~~~~
                                           %lu
    compiler-rt/lib/sanitizer_common/sanitizer_common.h:231:46: note: expanded from macro 'VReport'
        if ((uptr)Verbosity() >= (level)) Report(__VA_ARGS__); \
                                                 ^~~~~~~~~~~

Since `__sanitizer::uptr` has the same size as `size_t`, consistently
use `%z` as a printf specifier.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D114466




More information about the All-commits mailing list