[all-commits] [llvm/llvm-project] a4fd8c: [mlir][linalg] Update failure conditions for padOp...

Tobias Gysi via All-commits all-commits at lists.llvm.org
Wed Nov 24 11:11:34 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a4fd8cb76f8169e26f17e04d9a265a28531e4520
      https://github.com/llvm/llvm-project/commit/a4fd8cb76f8169e26f17e04d9a265a28531e4520
  Author: Tobias Gysi <gysit at google.com>
  Date:   2021-11-24 (Wed, 24 Nov 2021)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
    M mlir/test/Dialect/Linalg/pad.mlir
    M mlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp

  Log Message:
  -----------
  [mlir][linalg] Update failure conditions for padOperandToSmallestStaticBoundingBox.

Change the failure condition of padOperandToSmallestStaticBoundingBox to never fail if the operand is already statically sized.

In particular:
- if the padding value computation fails -> return failure if the operand shape is dynamic and success if it is static.
- if there is no extract slice op -> return failure if the operand shape is dynamic and success if it is static.

The latter change prevents padding from failure if the output operand passed by iteration argument is statically sized since in this case the extract / insert slice pairs are removed by canonicalization.

Depends On D114153

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D114161




More information about the All-commits mailing list