[all-commits] [llvm/llvm-project] 41c85b: [X86][NFC] Pre-commit test to show prolog insert p...

Phoebe Wang via All-commits all-commits at lists.llvm.org
Tue Nov 23 20:16:15 PST 2021


  Branch: refs/heads/release/13.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 41c85bbb43e466cad841bae48563d53ae8d5a456
      https://github.com/llvm/llvm-project/commit/41c85bbb43e466cad841bae48563d53ae8d5a456
  Author: Phoebe Wang <pengfei.wang at intel.com>
  Date:   2021-11-23 (Tue, 23 Nov 2021)

  Changed paths:
    A llvm/test/CodeGen/X86/vaargs-prolog-insert.ll

  Log Message:
  -----------
  [X86][NFC] Pre-commit test to show prolog insert problem


  Commit: 19b8368225dc9ec5a0da547eae48c10dae13522d
      https://github.com/llvm/llvm-project/commit/19b8368225dc9ec5a0da547eae48c10dae13522d
  Author: Phoebe Wang <pengfei.wang at intel.com>
  Date:   2021-11-23 (Tue, 23 Nov 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ExpandPseudo.cpp
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/Target/X86/X86ISelLowering.h
    M llvm/lib/Target/X86/X86InstrCompiler.td
    M llvm/lib/Target/X86/X86InstrInfo.td
    M llvm/test/CodeGen/X86/vaargs-prolog-insert.ll

  Log Message:
  -----------
  [X86][VARARG] Assign MMO earlier to avoid prolog insert point been sunk across VASTART_SAVE_XMM_REGS

The changes in D80163 defered the assignment of MachineMemOperand (MMO)
until the X86ExpandPseudo pass. This will result in crash due to prolog
insert point been sunk across the pseudo instruction VASTART_SAVE_XMM_REGS.

Moving the assignment to the creation of the node can avoid the problem.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D112859


Compare: https://github.com/llvm/llvm-project/compare/9dc7d6d5e326...19b8368225dc


More information about the All-commits mailing list