[all-commits] [llvm/llvm-project] e7cee5: [libc++] Remove uses of printf in some test suppor...

Louis Dionne via All-commits all-commits at lists.llvm.org
Mon Nov 22 09:02:08 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e7cee55c9d6b178baae3388ae2f620b44cf51e63
      https://github.com/llvm/llvm-project/commit/e7cee55c9d6b178baae3388ae2f620b44cf51e63
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-11-22 (Mon, 22 Nov 2021)

  Changed paths:
    M libcxx/test/support/controlled_allocators.h
    M libcxx/test/support/type_id.h
    M libcxx/test/support/uses_alloc_types.h

  Log Message:
  -----------
  [libc++] Remove uses of printf in some test support headers

In the test suite, we generally don't use printf or other reporting
utilities. It's not that it wouldn't be useful, it's just that some
platforms don't support IO.

Instead, we try to keep test cases small and self-contained so that
we can reasonably easily reproduce failures locally and debug them.
This patch removes printf in some of the last places in the test suite
that used it. The only remaining places are in a deque test and in the
filesystem tests. The filesystem tests are arguably fine to keep using
IO, since we're testing <filesystem>. The deque test will be handled
separately.

Differential Revision: https://reviews.llvm.org/D114282




More information about the All-commits mailing list