[all-commits] [llvm/llvm-project] f764a1: [clangd] Avoid possible crash: apply configuration...

Sam McCall via All-commits all-commits at lists.llvm.org
Fri Nov 19 16:13:56 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f764a1a5bd7c281d3d7cc3c6d7f1430711176762
      https://github.com/llvm/llvm-project/commit/f764a1a5bd7c281d3d7cc3c6d7f1430711176762
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2021-11-20 (Sat, 20 Nov 2021)

  Changed paths:
    M clang-tools-extra/clangd/ClangdLSPServer.cpp

  Log Message:
  -----------
  [clangd] Avoid possible crash: apply configuration after binding methods

The configuration may kick off indexing, which may involve sending LSP
messages.
The crash is fiddly to reproduce in a hermetic test (we need background
indexing on without disk storage, and to handle server->client messages
in LSPClient...)

Fixes https://github.com/clangd/clangd/issues/926




More information about the All-commits mailing list