[all-commits] [llvm/llvm-project] 4c9476: [ORC] Fix materialization of weak local symbols

Ben Langmuir via All-commits all-commits at lists.llvm.org
Fri Nov 19 07:26:11 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4c94760f360bd4e24519a61bea3bde0413aaf78a
      https://github.com/llvm/llvm-project/commit/4c94760f360bd4e24519a61bea3bde0413aaf78a
  Author: Ben Langmuir <blangmuir at apple.com>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
    A llvm/test/ExecutionEngine/JITLink/X86/MachO_weak_local.s

  Log Message:
  -----------
  [ORC] Fix materialization of weak local symbols

We were adding all defined weak symbols to the materialization
responsibility, but local symbols will not be in the symbol table, so it
failed to materialize due to the "missing" symbol.

Local weak symbols come up in practice when using `ld -r` with a hidden
weak symbol.

rdar://85574696




More information about the All-commits mailing list