[all-commits] [llvm/llvm-project] bc20bc: [lld/mac] Crash even less on undefined symbols wit...

Nico Weber via All-commits all-commits at lists.llvm.org
Fri Nov 19 06:23:53 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bc20bcb39e02e7b593fe0f50fe47959b635f5e56
      https://github.com/llvm/llvm-project/commit/bc20bcb39e02e7b593fe0f50fe47959b635f5e56
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M lld/MachO/ICF.cpp
    M lld/test/MachO/invalid/undefined-symbol.s

  Log Message:
  -----------
  [lld/mac] Crash even less on undefined symbols with --icf=all

Follow-up to https://reviews.llvm.org/D112643. Even after that change, we were
still asserting if two separate functions that are eligible for ICF (same size,
same data, same number of relocs, same reloc types, ...) referred to
Undefineds. This fixes that oversight.

Differential Revision: https://reviews.llvm.org/D114195




More information about the All-commits mailing list