[all-commits] [llvm/llvm-project] 55a793: [clang][clangd] Improve signature help for variadi...

[Adam Czachorowski via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 55a79318c60d8a39329195f43bf43b89da9a638e
      https://github.com/llvm/llvm-project/commit/55a79318c60d8a39329195f43bf43b89da9a638e
  Author: Adam Czachorowski <adamcz at google.com>
  Date:   2021-11-18 (Thu, 18 Nov 2021)

  Changed paths:
    M clang-tools-extra/clangd/CodeComplete.cpp
    M clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
    M clang/include/clang/Sema/Overload.h
    M clang/lib/Sema/SemaCodeComplete.cpp
    M clang/lib/Sema/SemaOverload.cpp
    A clang/test/CodeCompletion/variadic-template.cpp

  Log Message:
  -----------
  [clang][clangd] Improve signature help for variadic functions.

This covers both C-style variadic functions and template variadic w/
parameter packs.

Previously we would return no signatures when working with template
variadic functions once activeParameter reached the position of the
parameter pack (except when it was the only param, then we'd still
show it when no arguments were given). With this commit, we now show
signathure help correctly.

Additionally, this commit fixes the activeParameter value in LSP output
of clangd in the presence of variadic functions (both kinds). LSP does
not allow the activeParamter to be higher than the number of parameters
in the active signature. With "..." or parameter pack being just one
argument, for all but first argument passed to "..." we'd report
incorrect activeParameter value. Clients such as VSCode would then treat
it as 0, as suggested in the spec) and highlight the wrong parameter.

In the future, we should add support for per-signature activeParamter
value, which exists in LSP since 3.16.0. This is not part of this
commit.

Differential Revision: https://reviews.llvm.org/D111318