[all-commits] [llvm/llvm-project] 062ef8: [Driver][Android] Remove unneeded isNoExecStackDef...

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Nov 17 18:15:37 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 062ef8f6b472a71685941391ab93bfd68ce93d71
      https://github.com/llvm/llvm-project/commit/062ef8f6b472a71685941391ab93bfd68ce93d71
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-11-17 (Wed, 17 Nov 2021)

  Changed paths:
    M clang/include/clang/Driver/ToolChain.h
    M clang/lib/Driver/ToolChain.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/Gnu.cpp
    M clang/lib/Driver/ToolChains/Linux.cpp
    M clang/lib/Driver/ToolChains/Linux.h
    M clang/test/Driver/integrated-as.c
    M clang/test/Driver/linux-as.c
    M clang/test/Driver/linux-ld.c

  Log Message:
  -----------
  [Driver][Android] Remove unneeded isNoExecStackDefault

ld.lld used by Android ignores .note.GNU-stack and defaults to noexecstack,
so the `-z noexecstack` linker option is unneeded.

The `--noexecstack` assembler option is unneeded because AsmPrinter.cpp
prints `.section .note.GNU-stack,"", at progbits` (when `llvm.init.trampoline` is unused),
so the assembler won't synthesize an executable .note.GNU-stack.

Reviewed By: danalbert

Differential Revision: https://reviews.llvm.org/D113840




More information about the All-commits mailing list