[all-commits] [llvm/llvm-project] 4ea066: [clangd] Fix assertion crashes on unmatched NOLINT...

[Haojian Wu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ea066acc928d772c2a610024b7f0656b36e6afd
      https://github.com/llvm/llvm-project/commit/4ea066acc928d772c2a610024b7f0656b36e6afd
  Author: Haojian Wu <hokein.wu at gmail.com>
  Date:   2021-11-17 (Wed, 17 Nov 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
    M clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
    M clang-tools-extra/clangd/ParsedAST.cpp
    M clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

  Log Message:
  -----------
  [clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments.

The overload shouldSuppressDiagnostic seems unnecessary, and it is only
used in clangd.

This patch removes it and use the real one (suppression diagnostics are
discarded in clangd at the moment).

Fixes https://github.com/clangd/clangd/issues/929

Differential Revision: https://reviews.llvm.org/D113999