[all-commits] [llvm/llvm-project] 033b94: lsan: remove pthread_detach/join interceptors

Dmitry Vyukov via All-commits all-commits at lists.llvm.org
Wed Nov 17 05:49:27 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 033b94ab52992ec9c450d86f418f3791a8d8901c
      https://github.com/llvm/llvm-project/commit/033b94ab52992ec9c450d86f418f3791a8d8901c
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-11-17 (Wed, 17 Nov 2021)

  Changed paths:
    M compiler-rt/lib/lsan/lsan_fuchsia.cpp
    M compiler-rt/lib/lsan/lsan_interceptors.cpp
    M compiler-rt/lib/lsan/lsan_mac.cpp
    M compiler-rt/lib/lsan/lsan_posix.cpp
    M compiler-rt/lib/lsan/lsan_thread.cpp
    M compiler-rt/lib/lsan/lsan_thread.h

  Log Message:
  -----------
  lsan: remove pthread_detach/join interceptors

They don't seem to do anything useful in lsan.
They are needed only if a tools needs to execute
some custom logic during detach/join, or if it uses
thread registry quarantine. Lsan does none of this.
And if a tool cares then it would also need to intercept
pthread_tryjoin_np and pthread_timedjoin_np, otherwise
it will mess thread states.
Fwiw, asan does not intercept these functions either.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D113920




More information about the All-commits mailing list