[all-commits] [llvm/llvm-project] 86b310: [DebugInfo] Use DbgEntityKind in DbgEntity interfa...

[Aaron Puchert via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 86b3100cde841b2344327f8f628b8a09a4ac5b0c
      https://github.com/llvm/llvm-project/commit/86b3100cde841b2344327f8f628b8a09a4ac5b0c
  Author: Aaron Puchert <aaronpuchert at alice-dsl.net>
  Date:   2021-11-17 (Wed, 17 Nov 2021)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h

  Log Message:
  -----------
  [DebugInfo] Use DbgEntityKind in DbgEntity interface (NFC)

It was being used occasionally already, and using it on the constructor
and getDbgEntityID has obvious type safety benefits.

Also use llvm_unreachable in the switch as usual, but since only these
two values are used in constructor calls I think it's still NFC.

Reviewed By: probinson

Differential Revision: https://reviews.llvm.org/D113862


  Commit: b20da5117fb66e7f9bcb56cb14af86dcafe2ee9a
      https://github.com/llvm/llvm-project/commit/b20da5117fb66e7f9bcb56cb14af86dcafe2ee9a
  Author: Aaron Puchert <aaronpuchert at alice-dsl.net>
  Date:   2021-11-17 (Wed, 17 Nov 2021)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp

  Log Message:
  -----------
  Don't add irrelevant items to queue in DwarfCompileUnit::createScopeChildrenDIE (NFC)

Instead of popping them and then immediately throwing them away, we can
just filter out globals and items in different scopes before adding them
to WorkList. Shouldn't change anything but keep the queue smaller.

Reviewed By: aprantl

Differential Revision: https://reviews.llvm.org/D113864


Compare: https://github.com/llvm/llvm-project/compare/8b8e8704cebe...b20da5117fb6