[all-commits] [llvm/llvm-project] a0f1f1: DebugInfo: Stop modifying Operation::Error inside ...

[Duncan P. N. Exon Smith via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a0f1f171314f99351d47d033b13a5aea6c5ee84e
      https://github.com/llvm/llvm-project/commit/a0f1f171314f99351d47d033b13a5aea6c5ee84e
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2021-11-16 (Tue, 16 Nov 2021)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h
    M llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp

  Log Message:
  -----------
  DebugInfo: Stop modifying Operation::Error inside of verify()

The only caller of Operation::verify() is DWARFExpression::verify(),
which iterates past the (ephemeral) Operation immediately after.

- Stop setting Operation::Error because the mutation will never be
  observed.
- Change verify() to a static function to be sure all callers are
  updated.

Differential Revision: https://reviews.llvm.org/D113957