[all-commits] [llvm/llvm-project] b4e50e: [asm] Make EmitMSInlineAsmStr and EmitGCCInlineAsm...

Nico Weber via All-commits all-commits at lists.llvm.org
Mon Nov 15 12:47:49 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b4e50e52280be3378c2aad1fbc547fb669e931e8
      https://github.com/llvm/llvm-project/commit/b4e50e52280be3378c2aad1fbc547fb669e931e8
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-11-15 (Mon, 15 Nov 2021)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp

  Log Message:
  -----------
  [asm] Make EmitMSInlineAsmStr and EmitGCCInlineAsmStr more alike

https://reviews.llvm.org/D71677 copied a bunch of code from
EmitGCCInlineAsmStr() to EmitMSInlineAsmStr() but made a few small
(likely unintentional) changes. This makes these pieces look the same.

No behavior change.

(Why are these functions two copies? No great reason as far as I can tell.
https://reviews.llvm.org/rG1778831a3d1d24ab6545635f63da4d9c5f8f0ac7 did the
split; we might want to undo them at some point. But PR23933 suggests
that a bigger change is planned for this file in the future, so keeping
this incremental for now.)

Differential Revision: https://reviews.llvm.org/D113924




More information about the All-commits mailing list