[all-commits] [llvm/llvm-project] 00ff77: [CMake] Allow passing extra options to extract_sym...

Simon Tatham via All-commits all-commits at lists.llvm.org
Mon Nov 15 06:02:26 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 00ff774fca787af4fecbcab6d7ee5f454127c8a1
      https://github.com/llvm/llvm-project/commit/00ff774fca787af4fecbcab6d7ee5f454127c8a1
  Author: Simon Tatham <simon.tatham at arm.com>
  Date:   2021-11-15 (Mon, 15 Nov 2021)

  Changed paths:
    M llvm/CMakeLists.txt
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [CMake] Allow passing extra options to extract_symbols.py.

When cross-compiling LLVM in an environment where there //is// an
objdump binary available but it does not understand the target
platform's object file format, extract_symbols.py fails, because its
initial check for tool availability decides that the existence of
objdump at all is good enough to settle on it as the tool of choice.

In such an environment it's useful to work around this by telling
extract_symbols.py to use llvm-readobj instead. The script itself has
an option for that, but its invocation in AddLLVM.cmake wasn't
providing a mechanism to add extra options passed through for the
cmake command line.

Reviewed By: DavidSpickett

Differential Revision: https://reviews.llvm.org/D113557




More information about the All-commits mailing list