[all-commits] [llvm/llvm-project] 69be35: Reapply "[ORC] Initial MachO debugging support (vi...

[lhames via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 69be352a1961ac3a51fcd87e461a70b926639613
      https://github.com/llvm/llvm-project/commit/69be352a1961ac3a51fcd87e461a70b926639613
  Author: Lang Hames <lhames at gmail.com>
  Date:   2021-11-14 (Sun, 14 Nov 2021)

  Changed paths:
    M llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
    A llvm/include/llvm/ExecutionEngine/Orc/DebuggerSupportPlugin.h
    M llvm/lib/ExecutionEngine/JITLink/JITLinkMemoryManager.cpp
    M llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.cpp
    M llvm/lib/ExecutionEngine/Orc/CMakeLists.txt
    A llvm/lib/ExecutionEngine/Orc/DebuggerSupportPlugin.cpp
    M llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.cpp
    A llvm/test/ExecutionEngine/JITLink/X86/MachO_gdb_jit_debuginfo_register.s
    R llvm/test/ExecutionEngine/JITLink/X86/MachO_skip_debug_sections.s
    M llvm/tools/llvm-jitlink/llvm-jitlink.cpp

  Log Message:
  -----------
  Reapply "[ORC] Initial MachO debugging support (via GDB JIT debug.." with fixes.

This reapplies e1933a0488a50eb939210808fc895d374570d891 (which was reverted in
f55ba3525eb19baed7d3f23638cbbd880246a370 due to bot failures, e.g.
https://lab.llvm.org/buildbot/#/builders/117/builds/2768).

The bot failures were due to a missing symbol error: We use the input object's
mangling to decide how to mangle the debug-info registration function name. This
caused lookup of the registration function to fail when the input object
mangling didn't match the host mangling.

Disbaling the test on non-Darwin platforms is the easiest short-term solution.
I have filed https://llvm.org/PR52503 with a proposed longer term solution.