[all-commits] [llvm/llvm-project] e7b1dc: [X86][NFC] Pre-commit test to show prolog insert p...

Phoebe Wang via All-commits all-commits at lists.llvm.org
Fri Nov 12 19:36:40 PST 2021


  Branch: refs/heads/forTom
  Home:   https://github.com/llvm/llvm-project
  Commit: e7b1dc9a9dbabf0a13a76d44ccccb179c0230222
      https://github.com/llvm/llvm-project/commit/e7b1dc9a9dbabf0a13a76d44ccccb179c0230222
  Author: Phoebe Wang <pengfei.wang at intel.com>
  Date:   2021-11-13 (Sat, 13 Nov 2021)

  Changed paths:
    A llvm/test/CodeGen/X86/vaargs-prolog-insert.ll

  Log Message:
  -----------
  [X86][NFC] Pre-commit test to show prolog insert problem


  Commit: a566a4b21157e7aedb6d4230f61e09f6cd3152ce
      https://github.com/llvm/llvm-project/commit/a566a4b21157e7aedb6d4230f61e09f6cd3152ce
  Author: Phoebe Wang <pengfei.wang at intel.com>
  Date:   2021-11-13 (Sat, 13 Nov 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ExpandPseudo.cpp
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/Target/X86/X86ISelLowering.h
    M llvm/lib/Target/X86/X86InstrCompiler.td
    M llvm/lib/Target/X86/X86InstrInfo.td
    M llvm/test/CodeGen/X86/vaargs-prolog-insert.ll

  Log Message:
  -----------
  [X86][VARARG] Assign MMO earlier to avoid prolog insert point been sunk across VASTART_SAVE_XMM_REGS

The changes in D80163 defered the assignment of MachineMemOperand (MMO)
until the X86ExpandPseudo pass. This will result in crash due to prolog
insert point been sunk across the pseudo instruction VASTART_SAVE_XMM_REGS.

Moving the assignment to the creation of the node can avoid the problem.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D112859


Compare: https://github.com/llvm/llvm-project/compare/e7b1dc9a9dba%5E...a566a4b21157


More information about the All-commits mailing list