[all-commits] [llvm/llvm-project] c3edab: ADT: Avoid repeating iterator adaptor/facade templ...

[Duncan P. N. Exon Smith via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c3edab8f781d0c3cf063ec0c675ad7bd7c3b65b8
      https://github.com/llvm/llvm-project/commit/c3edab8f781d0c3cf063ec0c675ad7bd7c3b65b8
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2021-11-12 (Fri, 12 Nov 2021)

  Changed paths:
    M llvm/include/llvm/ADT/STLExtras.h
    M llvm/include/llvm/DebugInfo/PDB/Native/DbiModuleList.h
    M llvm/include/llvm/DebugInfo/PDB/Native/HashTable.h
    M llvm/unittests/ADT/IteratorTest.cpp

  Log Message:
  -----------
  ADT: Avoid repeating iterator adaptor/facade template params, NFC

Take advantage of class name injection to avoid redundantly specifying
template parameters of iterator adaptor/facade base classes.

No functionality change, although the private typedefs changed in a
couple of cases.

  - Added a private typedef HashTableIterator::BaseT, following the
    pattern from r207084 / 3478d4b164e8d3eba01f5bfa3fc5bfb287a78b97, to
    pre-emptively appease MSVC (maybe it's not necessary anymore but
    looks like we do this pretty consistently). Otherwise, I removed
    private
  - Removed private typedefs filter_iterator_impl::BaseT and
    FilterIteratorTest::InputIterator::BaseT since there was only one
    use of each and the definition was no longer interesting.