[all-commits] [llvm/llvm-project] 4e7df1: Comment AST: Find out if function is variadic in D...

[Aaron Puchert via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e7df1ef7b679953c1501177539166876c4cbda4
      https://github.com/llvm/llvm-project/commit/4e7df1ef7b679953c1501177539166876c4cbda4
  Author: Aaron Puchert <aaron.puchert at sap.com>
  Date:   2021-11-12 (Fri, 12 Nov 2021)

  Changed paths:
    M clang/include/clang/AST/Comment.h
    M clang/lib/AST/Comment.cpp
    M clang/lib/AST/CommentSema.cpp
    M clang/test/Sema/warn-documentation.cpp

  Log Message:
  -----------
  Comment AST: Find out if function is variadic in DeclInfo::fill

Then we don't have to look into the declaration again. Also it's only
natural to collect this information alongside parameters and return
type, as it's also just a parameter in some sense.

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D113690


  Commit: 3010883fc296619def051e0a2f97d40fb15960d7
      https://github.com/llvm/llvm-project/commit/3010883fc296619def051e0a2f97d40fb15960d7
  Author: Aaron Puchert <aaron.puchert at sap.com>
  Date:   2021-11-12 (Fri, 12 Nov 2021)

  Changed paths:
    M clang/include/clang/AST/Comment.h
    M clang/include/clang/AST/CommentSema.h
    M clang/lib/AST/Comment.cpp
    M clang/lib/AST/CommentSema.cpp

  Log Message:
  -----------
  Comment AST: Recognize function-like objects via return type (NFC)

Instead of pretending that function pointer type aliases or variables
are functions, and thereby losing the information that they are type
aliases or variables, respectively, we use the existence of a return
type in the DeclInfo to signify a "function-like" object.

That seems pretty natural, since it's also the return type (or parameter
list) from the DeclInfo that we compare the documentation with.

Addresses a concern voiced in D111264#3115104.

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D113691


  Commit: 59b1e98137e961a61ffaeb609b6790999c461bec
      https://github.com/llvm/llvm-project/commit/59b1e98137e961a61ffaeb609b6790999c461bec
  Author: Aaron Puchert <aaron.puchert at sap.com>
  Date:   2021-11-12 (Fri, 12 Nov 2021)

  Changed paths:
    M clang/include/clang/AST/CommentSema.h

  Log Message:
  -----------
  Comment Sema: Make most of CommentSema private (NFC)

We only need to expose setDecl, copyArray and the actOn* methods.


Compare: https://github.com/llvm/llvm-project/compare/5074a20dec70...59b1e98137e9