[all-commits] [llvm/llvm-project] 9d5e64: [JITLink] Fix think-o in handwritten CWrapperFunct...

lhames via All-commits all-commits at lists.llvm.org
Fri Nov 12 10:36:45 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d5e6474281cd4d774ede800eb339e1dc610e471
      https://github.com/llvm/llvm-project/commit/9d5e6474281cd4d774ede800eb339e1dc610e471
  Author: Lang Hames <lhames at gmail.com>
  Date:   2021-11-12 (Fri, 12 Nov 2021)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/JITLinkMemoryManager.cpp

  Log Message:
  -----------
  [JITLink] Fix think-o in handwritten CWrapperFunctionResult -> Error converter.

We need to skip the length field when generating error strings.

No test case: This hand-hacked deserializer should be removed in the near future
once JITLink can use generic ORC APIs (including SPS and WrapperFunction).


  Commit: 3fb641618f1a3b73c0bd661c567e8db32dcde491
      https://github.com/llvm/llvm-project/commit/3fb641618f1a3b73c0bd661c567e8db32dcde491
  Author: Lang Hames <lhames at gmail.com>
  Date:   2021-11-12 (Fri, 12 Nov 2021)

  Changed paths:
    M compiler-rt/lib/orc/macho_platform.cpp
    M llvm/tools/llvm-jitlink/llvm-jitlink.cpp

  Log Message:
  -----------
  [ORC-RT][llvm-jitlink] Fix a buggy check in ORC-RT MachO TLV deregistration.

The check was failing because it was matching against the end of the range, not
the start.

This bug wasn't causing the ORC-RT MachO TLV regression test to fail because
we were only logging deallocation errors (including TLV deregistration errors)
and not actually returning a failure code. This commit updates llvm-jitlink to
report the errors properly.


Compare: https://github.com/llvm/llvm-project/compare/f453e23e67e2...3fb641618f1a


More information about the All-commits mailing list