[all-commits] [llvm/llvm-project] f1a2b5: [flang][nfc] Tidy up in CodeGen.cpp and TypeConver...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f1a2b507896c3fec8b725e489d9c0a9816d292c0
      https://github.com/llvm/llvm-project/commit/f1a2b507896c3fec8b725e489d9c0a9816d292c0
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2021-11-11 (Thu, 11 Nov 2021)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/CodeGen.cpp
    M flang/lib/Optimizer/CodeGen/TypeConverter.h

  Log Message:
  -----------
  [flang][nfc] Tidy up in CodeGen.cpp and TypeConverter.h

Some header `#include`s that belong in TypeConverter.h rather than in
CodeGen.cpp are moved accordingly. As TypeConverter.h is currently only
used in CodeGen.cpp, this wouldn't cause any build issues (ultimately,
all the required headers are included). However, this would become a problem
when including TypeConverter.h elsewhere.

Also, from [1], "(...) include all of the header files that you are
using ". This is currently not the case in TypeConverter.h and hence the
`#include`s should be moved.

I've also added missing namespace qualifiers in a few places in
TypeConverter.h

[1] https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible

Differential Revision: https://reviews.llvm.org/D113569