[all-commits] [llvm/llvm-project] 360d90: Revert "[lldb] Disable minimal import mode for Rec...

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Wed Nov 10 10:39:01 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 360d901bf0478293d6e57f58bdb63b386f97f531
      https://github.com/llvm/llvm-project/commit/360d901bf0478293d6e57f58bdb63b386f97f531
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2021-11-10 (Wed, 10 Nov 2021)

  Changed paths:
    M lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
    A lldb/test/API/commands/expression/pr52257/Makefile
    A lldb/test/API/commands/expression/pr52257/TestExprCrash.py
    A lldb/test/API/commands/expression/pr52257/main.cpp
    M lldb/test/API/lang/cpp/reference-to-outer-type/TestCppReferenceToOuterClass.py

  Log Message:
  -----------
  Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

This reverts commit 3bf96b0329be554c67282b0d7d8da6a864b9e38f.

It causes crashes as reported in PR52257 and a few other places. A reproducer is bundled with this commit to verify any fix forward. The original test is left in place, but marked XFAIL as it now produces the wrong result.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D113449




More information about the All-commits mailing list