[all-commits] [llvm/llvm-project] b4f6f1: [clang-tidy] Fix llvm-header-guard so that it work...

Salman Javed via All-commits all-commits at lists.llvm.org
Tue Nov 9 21:44:46 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b4f6f1c9369ec4bb1c10852283a8c7e8c39e1a8d
      https://github.com/llvm/llvm-project/commit/b4f6f1c9369ec4bb1c10852283a8c7e8c39e1a8d
  Author: Salman Javed <mail at salmanjaved.org>
  Date:   2021-11-10 (Wed, 10 Nov 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp
    M clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp

  Log Message:
  -----------
  [clang-tidy] Fix llvm-header-guard so that it works with Windows paths

Fixes pr40372 (https://bugs.llvm.org/show_bug.cgi?id=40372).

The llvm-header-guard check does not take into account that the path
separator on Windows is `\`, not `/`.

This means that instead of suggesting a header guard in the form of:
LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_FOO_H

it incorrectly suggests:
C:\LLVM_PROJECT\CLANG_TOOLS_EXTRA\CLANG_TIDY\FOO_H

Differential Revision: https://reviews.llvm.org/D113450




More information about the All-commits mailing list