[all-commits] [llvm/llvm-project] 3506e4: Comment AST: Factor out function type extraction i...

[Aaron Puchert via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3506e42ab67eef41a1f27e180e7c552a2ffff7bb
      https://github.com/llvm/llvm-project/commit/3506e42ab67eef41a1f27e180e7c552a2ffff7bb
  Author: Aaron Puchert <aaron.puchert at sap.com>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M clang/lib/AST/Comment.cpp

  Log Message:
  -----------
  Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D111262


  Commit: 4d6382430066465774f6f696ea3f4c402da1d705
      https://github.com/llvm/llvm-project/commit/4d6382430066465774f6f696ea3f4c402da1d705
  Author: Aaron Puchert <aaron.puchert at sap.com>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M clang/include/clang/AST/Comment.h
    M clang/include/clang/AST/CommentSema.h
    M clang/lib/AST/Comment.cpp
    M clang/lib/AST/CommentSema.cpp
    M clang/test/Sema/warn-documentation.cpp
    M clang/test/Sema/warn-documentation.m

  Log Message:
  -----------
  Comment AST: Declare function pointer variables as functions

We were doing this already for type aliases, and it deduplicates the
code looking through aliases and pointers to find a function type. As
a side effect, this finds two warnings that we apparently missed before.

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D111264


  Commit: 63ef0e17e28827eae53133b3467bdac7d9729318
      https://github.com/llvm/llvm-project/commit/63ef0e17e28827eae53133b3467bdac7d9729318
  Author: Aaron Puchert <aaron.puchert at sap.com>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M clang/include/clang/AST/Comment.h
    M clang/lib/AST/Comment.cpp
    M clang/test/Sema/warn-documentation.cpp

  Log Message:
  -----------
  Comment AST: Add support for variable templates

We treat them as variables of course, though if they have function
pointer type we treat them as functions, i.e. allow parameter and return
value specifications. Just like VarDecls.

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D111266


Compare: https://github.com/llvm/llvm-project/compare/24e07e1cf588...63ef0e17e288