[all-commits] [llvm/llvm-project] de12ca: [InstCombine] fix typo in test; NFC

RotateRight via All-commits all-commits at lists.llvm.org
Tue Nov 9 09:46:19 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: de12ca31d477d4a5f6c5d84504eb99f54e7dc2dc
      https://github.com/llvm/llvm-project/commit/de12ca31d477d4a5f6c5d84504eb99f54e7dc2dc
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M llvm/test/Transforms/InstCombine/sub-minmax.ll

  Log Message:
  -----------
  [InstCombine] fix typo in test; NFC

This was intended to commute the previous test, but failed to swap the values.


  Commit: 2a88d00cf250534f31c706bc832f0f6386c28ef3
      https://github.com/llvm/llvm-project/commit/2a88d00cf250534f31c706bc832f0f6386c28ef3
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
    M llvm/test/Transforms/InstCombine/sub-minmax.ll

  Log Message:
  -----------
  [InstCombine] fold sub-of-umax to 0-usubsat

Op0 - umax(X, Op0) --> 0 - usub.sat(X, Op1)

I'm not sure if this is really an improvement in IR because
we probably have better recognition/analysis for min/max,
but this lines up with the fold we do for the icmp+select
idiom and removes another diff from D98152.

This is similar to the previous fold in the code that was
added with:
83c2fb9f66be
baa6a851308d

https://alive2.llvm.org/ce/z/5MrVB9


Compare: https://github.com/llvm/llvm-project/compare/c9881c7d99c6...2a88d00cf250


More information about the All-commits mailing list