[all-commits] [llvm/llvm-project] 007695: [clang-tidy] Fix lint warning in ClangTidyDiagnost...

Salman Javed via All-commits all-commits at lists.llvm.org
Tue Nov 9 04:11:46 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 00769572025f9b0d36dc832d3c1bc61500091ed5
      https://github.com/llvm/llvm-project/commit/00769572025f9b0d36dc832d3c1bc61500091ed5
  Author: Salman Javed <mail at salmanjaved.org>
  Date:   2021-11-10 (Wed, 10 Nov 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

  Log Message:
  -----------
  [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

Calling clang-tidy on ClangTidyDiagnosticConsumer.cpp gives a
"unmatched NOLINTBEGIN without a subsequent NOLINTEND" warning.

The "NOLINTBEGIN" and "NOLINTEND" string literals used in the
implementation of `createNolintError()` get mistaken for actual
NOLINTBEGIN/END comments used to suppress clang-tidy warnings.

Rewrite the string literals so that they can no longer be mistaken for
actual suppression comments.

Differential Revision: https://reviews.llvm.org/D113472




More information about the All-commits mailing list