[all-commits] [llvm/llvm-project] 46ec93: [Support] [VirtualFileSystem] Detect the windows_s...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Mon Nov 8 12:22:15 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 46ec93a457b07c4e1b07dbd7424343f7e9e66f6d
      https://github.com/llvm/llvm-project/commit/46ec93a457b07c4e1b07dbd7424343f7e9e66f6d
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M llvm/lib/Support/VirtualFileSystem.cpp

  Log Message:
  -----------
  [Support] [VirtualFileSystem] Detect the windows_slash path style

This fixes the following clang VFS tests, if `windows_slash` is the
default style:

  Clang :: VFS/implicit-include.c
  Clang :: VFS/relative-path.c
  Clang-Unit :: Frontend/./FrontendTests.exe/CompilerInstance.DefaultVFSOverlayFromInvocation

Also clarify a couple references to `Style::windows` into
`Style::windows_backslash`, to make it clearer that each of them are
opinionated in different directions (even if it doesn't matter for
calls to e.g. `is_absolute`).

Differential Revision: https://reviews.llvm.org/D113272


  Commit: 2ca6fc34fc08eaadb0f287a7f1b33bc1de4d1bd6
      https://github.com/llvm/llvm-project/commit/2ca6fc34fc08eaadb0f287a7f1b33bc1de4d1bd6
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp

  Log Message:
  -----------
  [clang] [DirectoryWatcher] Remove leading \\?\ from GetFinalPathNameByHandleW

This is needed for the paths to work when using forward slashes;
this fixes the DirectoryWatcherTests unit tests.

Also allocate missing space for the null terminator, which seems to
have been missing all along (writing the terminator out of bounds).

Differential Revision: https://reviews.llvm.org/D113264


  Commit: 98f0bf74ca6d7aa9b3c2b240693824f085aa6675
      https://github.com/llvm/llvm-project/commit/98f0bf74ca6d7aa9b3c2b240693824f085aa6675
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M clang-tools-extra/unittests/clang-move/ClangMoveTests.cpp

  Log Message:
  -----------
  [clang-move] Fix unit tests with forward slash as separator on windows

Also remove a comment that seems to be left behind.

Differential Revision: https://reviews.llvm.org/D113269


Compare: https://github.com/llvm/llvm-project/compare/e2b1d3260a30...98f0bf74ca6d


More information about the All-commits mailing list