[all-commits] [llvm/llvm-project] c51f94: [NFC][llvm-libtool-darwin] Remove unnecessary cond...

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Mon Nov 8 10:34:22 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c51f947a1351509dd68d8fe5843794ce0201b937
      https://github.com/llvm/llvm-project/commit/c51f947a1351509dd68d8fe5843794ce0201b937
  Author: Roger Kim <rgr at fb.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp

  Log Message:
  -----------
  [NFC][llvm-libtool-darwin] Remove unnecessary conditionals around errors

The existing code has unnecessary logic to indirectly pass
errors through function calls. This diff gets rid of the fluff.

Test Plan: Existing unit tests

Reviewed By: jhenderson, drodriguez, alexander-shaposhnikov

Differential Revision: https://reviews.llvm.org/D113301


  Commit: 1658980a1c82531774d04632fc4dfec9a3ed0f82
      https://github.com/llvm/llvm-project/commit/1658980a1c82531774d04632fc4dfec9a3ed0f82
  Author: Roger Kim <rgr at fb.com>
  Date:   2021-11-08 (Mon, 08 Nov 2021)

  Changed paths:
    M llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp

  Log Message:
  -----------
  [NFC][llvm-libtool-darwin] Clean up names

Removing unclear abbreviations.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D113215


Compare: https://github.com/llvm/llvm-project/compare/82568021ddf0...1658980a1c82


More information about the All-commits mailing list